Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix the GPU flavor problem for Scala #13889

Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix the GPU flavor problem for Scala #13889

merged 1 commit into from
Jan 15, 2019

Conversation

lanking520
Copy link
Member

Description

Currently the pom file configuration did not correctly find the libcuda name as well as path problems to fetch the libmxnet.so.
@frankfliu @zachgk @piyushghai @andrewfayres

Reference:

ldd -r libmxnet.so
	linux-vdso.so.1 =>  (0x00007ffffd3eb000)
	libcudart.so.9.2 => /home/ubuntu/mxnet/staticdeps/usr/local/cuda-9.2/lib64/libcudart.so.9.2 (0x00007f7c126d5000)
	libcublas.so.9.2 => /home/ubuntu/mxnet/staticdeps/usr/local/cuda-9.2/lib64/libcublas.so.9.2 (0x00007f7c0e907000)
	libcurand.so.9.2 => /home/ubuntu/mxnet/staticdeps/usr/local/cuda-9.2/lib64/libcurand.so.9.2 (0x00007f7c0a9c9000)
	libcusolver.so.9.2 => /home/ubuntu/mxnet/staticdeps/usr/local/cuda-9.2/lib64/libcusolver.so.9.2 (0x00007f7c03588000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f7c03380000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f7c0317c000)
	libgfortran.so.3 => /home/ubuntu/deploytest2/lib/./libgfortran.so.3 (0x00007f7c02e55000)
	libcufft.so.9.2 => /home/ubuntu/mxnet/staticdeps/usr/local/cuda-9.2/lib64/libcufft.so.9.2 (0x00007f7bfd7fb000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f7bfd4e5000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f7bfd1df000)
	libgomp.so.1 => /usr/lib/x86_64-linux-gnu/libgomp.so.1 (0x00007f7bfcfb0000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f7bfcd9a000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f7bfcb7c000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f7bfc7b3000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f7c3e2e1000)
	libquadmath.so.0 => /home/ubuntu/deploytest2/lib/./libquadmath.so.0 (0x00007f7bfc573000)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@stu1130
Copy link
Contributor

stu1130 commented Jan 15, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 15, 2019
frankfliu
frankfliu approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piyushghai
piyushghai approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 634d527 into apache:master Jan 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@lanking520 @stephenrawls
fix the fetching GPU problem (apache#13889)
f34dbbd
piyushghai pushed a commit to piyushghai/incubator-mxnet that referenced this pull request Feb 28, 2019
@lanking520 @piyushghai
fix the fetching GPU problem (apache#13889)
83e0d3e
@lanking520 lanking520 deleted the cudafix branch March 11, 2019 22:28
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
@lanking520
fix the fetching GPU problem (apache#13889)
9fcb653
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
@lanking520
fix the fetching GPU problem (apache#13889)
91280bb
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 30, 2019
@lanking520
fix the fetching GPU problem (apache#13889)
4eb2bc1
zachgk pushed a commit to zachgk/incubator-mxnet that referenced this pull request May 16, 2019
@lanking520 @zachgk
fix the fetching GPU problem (apache#13889)
7d7ec9e
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@lanking520
fix the fetching GPU problem (apache#13889)
2a7acb9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankfliu frankfliu frankfliu approved these changes

@piyushghai piyushghai piyushghai approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lanking520 @stu1130 @piyushghai @frankfliu @marcoabreu